]> git.puffer.fish Git - mirror/frr.git/commitdiff
ospfd: fix stylistic issue
authorQuentin Young <qlyoung@cumulusnetworks.com>
Mon, 16 Apr 2018 18:37:30 +0000 (14:37 -0400)
committerQuentin Young <qlyoung@cumulusnetworks.com>
Tue, 17 Apr 2018 17:58:24 +0000 (13:58 -0400)
Macro that expands to be wrapped in parentheses was being used as a raw
condition for an if statement, leading to some very weird and confusing
formatting...

Signed-off-by: Quentin Young <qlyoung@cumulusnetworks.com>
ospfd/ospf_te.c

index 05adc5aa4fe8aa2fdd10b6d64f6f92f1faa1d3ea..13857fd0bae335d7113dd67f5f0391cd0995dd8f 100644 (file)
@@ -1161,16 +1161,13 @@ static struct ospf_lsa *ospf_mpls_te_lsa_new(struct ospf *ospf,
 
        /* Set opaque-LSA header fields depending of the type of RFC */
        if (IS_INTER_AS(lp->type)) {
-               if
-                       IS_FLOOD_AS(lp->type)
-                       {
-                               options |= OSPF_OPTION_E; /* Enable AS external
-                                                            as we flood
-                                                            Inter-AS with
-                                                            Opaque Type 11 */
-                               lsa_type = OSPF_OPAQUE_AS_LSA;
-                       }
-               else {
+               if (IS_FLOOD_AS(lp->type)) {
+                       /* Enable AS external as we flood Inter-AS with Opaque
+                        * Type 11
+                        */
+                       options |= OSPF_OPTION_E;
+                       lsa_type = OSPF_OPAQUE_AS_LSA;
+               } else {
                        options |= LSA_OPTIONS_GET(
                                area); /* Get area default option */
                        options |= LSA_OPTIONS_NSSA_GET(area);