pimd: Dissallow obvious addresses from being the RP

When configuring a RP, dissallow the choice of 0.0.0.0 or
255.255.255.255 as the address as that they make no sense
what so ever.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

diff --git a/pimd/pim_rp.c b/pimd/pim_rp.c
index 35c040c64cec06019145ee85bb658bf3f35eab93..717566738f46315b73946352d90c1e79aedd2eb0 100644 (file)
--- a/pimd/pim_rp.c
+++ b/pimd/pim_rp.c
@@ -457,6 +457,10 @@ int pim_rp_new(struct pim_instance *pim, struct in_addr rp_addr,
        struct pim_upstream *up;
        struct listnode *upnode;
 
+       if (rp_addr.s_addr == INADDR_ANY ||
+           rp_addr.s_addr == INADDR_NONE)
+               return PIM_RP_BAD_ADDRESS;
+
        rp_info = XCALLOC(MTYPE_PIM_RP, sizeof(*rp_info));
 
        rp_info->rp.rpf_addr.family = AF_INET;