]> git.puffer.fish Git - mirror/frr.git/commitdiff
bgpd: Use interface name instead of pointer value 13014/head
authorDonald Sharp <sharpd@nvidia.com>
Thu, 16 Mar 2023 14:24:25 +0000 (10:24 -0400)
committerMergify <37929162+mergify[bot]@users.noreply.github.com>
Fri, 17 Mar 2023 07:56:44 +0000 (07:56 +0000)
Log message is borked in a manner that makes it unusable:
bgpd[52]: [VX6SM-8YE5W][EC 33554460] 2000:31:0:53::2: nexthop_set failed, resetting connection - intf 0x561eb9005a30

Let's print out the interface name instead.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
(cherry picked from commit 50e049db76573210e3b9ccfa962e5259452ccbe3)

bgpd/bgp_network.c

index 9ecc2ae4e42667a9c08a37bcc936ae3037f181d5..483f377dbe3c061e2d123330d4a19b2753f8f4d2 100644 (file)
@@ -790,9 +790,12 @@ int bgp_getsockname(struct peer *peer)
 
        if (!bgp_zebra_nexthop_set(peer->su_local, peer->su_remote,
                                   &peer->nexthop, peer)) {
-               flog_err(EC_BGP_NH_UPD,
-                        "%s: nexthop_set failed, resetting connection - intf %p",
-                        peer->host, peer->nexthop.ifp);
+               flog_err(
+                       EC_BGP_NH_UPD,
+                       "%s: nexthop_set failed, resetting connection - intf %s",
+                       peer->host,
+                       peer->nexthop.ifp ? peer->nexthop.ifp->name
+                                         : "(Unknown)");
                return -1;
        }
        return 0;