]> git.puffer.fish Git - mirror/frr.git/commitdiff
zebra: TODO for hanlding blackhole attr exclusive
authorStephen Worley <sworley@cumulusnetworks.com>
Mon, 26 Aug 2019 21:06:10 +0000 (17:06 -0400)
committerStephen Worley <sworley@cumulusnetworks.com>
Fri, 25 Oct 2019 15:13:42 +0000 (11:13 -0400)
Add a TODO statement for handling the exclusiveness
of blackhole attributes.

Signed-off-by: Stephen Worley <sworley@cumulusnetworks.com>
zebra/rt_netlink.c

index cdd7b5a92ad140e9a2b6a5e69ad4416b76f5c184..98fe8b2687254cebc31ac1a066dfcca97e779b6d 100644 (file)
@@ -2004,7 +2004,8 @@ static int netlink_nexthop(int cmd, struct zebra_dplane_ctx *ctx)
                                          &nh->gate.ipv6, IPV6_MAX_BYTELEN);
                                break;
                        case NEXTHOP_TYPE_BLACKHOLE:
-                               // TODO: Handle this
+                               // TODO: Handle this, Can't have OIF/Encap with
+                               // it
                                addattr_l(&req.n, sizeof(req), NHA_BLACKHOLE,
                                          NULL, 0);
                                break;
@@ -2237,6 +2238,7 @@ static struct nexthop netlink_nexthop_process_nh(struct rtattr **tb,
        if (tb[NHA_ENCAP] && tb[NHA_ENCAP_TYPE]) {
                uint16_t encap_type = *(uint16_t *)RTA_DATA(tb[NHA_ENCAP_TYPE]);
                int num_labels = 0;
+
                mpls_label_t labels[MPLS_MAX_LABELS] = {0};
 
                if (encap_type == LWTUNNEL_ENCAP_MPLS)