]> git.puffer.fish Git - matthieu/frr.git/commitdiff
bgpd: Use sizeof() in bgp_dump_attr()
authorDonatas Abraitis <donatas.abraitis@gmail.com>
Tue, 18 Aug 2020 18:43:07 +0000 (21:43 +0300)
committerDonatas Abraitis <donatas.abraitis@gmail.com>
Wed, 19 Aug 2020 12:54:05 +0000 (15:54 +0300)
Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
bgpd/bgp_evpn.c
bgpd/bgp_packet.c
bgpd/bgp_updgrp_packet.c

index a10686189d4c52acb4cad7e64ce3e12e2ac4be8d..bc991042baae5f493d8073fc158565aafb5e9b76 100644 (file)
@@ -3174,7 +3174,7 @@ static int bgp_evpn_route_rmac_self_check(struct bgp *bgp_vrf,
                        char buf1[PREFIX_STRLEN];
                        char attr_str[BUFSIZ] = {0};
 
-                       bgp_dump_attr(pi->attr, attr_str, BUFSIZ);
+                       bgp_dump_attr(pi->attr, attr_str, sizeof(attr_str));
 
                        zlog_debug("%s: bgp %u prefix %s with attr %s - DENIED due to self mac",
                                __func__, bgp_vrf->vrf_id,
@@ -5625,7 +5625,8 @@ int bgp_filter_evpn_routes_upon_martian_nh_change(struct bgp *bgp)
                                                char attr_str[BUFSIZ] = {0};
 
                                                bgp_dump_attr(pi->attr,
-                                                             attr_str, BUFSIZ);
+                                                             attr_str,
+                                                             sizeof(attr_str));
 
                                                zlog_debug(
                                                        "%u: prefix %pRN with attr %s - DENIED due to martian or self nexthop",
index 6f1c033f2a72a8640fcf5202504446bcbbc1f0c3..7b089922d4bad49982a347df9fd5bcfb28657276 100644 (file)
@@ -1580,7 +1580,8 @@ static int bgp_update_receive(struct peer *peer, bgp_size_t size)
        if (attr_parse_ret == BGP_ATTR_PARSE_WITHDRAW
            || BGP_DEBUG(update, UPDATE_IN)
            || BGP_DEBUG(update, UPDATE_PREFIX)) {
-               ret = bgp_dump_attr(&attr, peer->rcvd_attr_str, BUFSIZ);
+               ret = bgp_dump_attr(&attr, peer->rcvd_attr_str,
+                                   sizeof(peer->rcvd_attr_str));
 
                peer->stat_upd_7606++;
 
index 8d6fc1f6a27779b866cc8ffd5f850b2d6d89d312..8ebfdb30264014d77cc89ef9fe908e26eb11fdc4 100644 (file)
@@ -824,7 +824,7 @@ struct bpacket *subgroup_update_packet(struct update_subgroup *subgrp)
                                memset(send_attr_str, 0, BUFSIZ);
                                send_attr_printed = 0;
                                bgp_dump_attr(adv->baa->attr, send_attr_str,
-                                             BUFSIZ);
+                                             sizeof(send_attr_str));
                        }
                }
 
@@ -1140,7 +1140,7 @@ void subgroup_default_update_packet(struct update_subgroup *subgrp,
 
                attrstr[0] = '\0';
 
-               bgp_dump_attr(attr, attrstr, BUFSIZ);
+               bgp_dump_attr(attr, attrstr, sizeof(attrstr));
 
                if (addpath_encode)
                        snprintf(tx_id_buf, sizeof(tx_id_buf),