]> git.puffer.fish Git - mirror/frr.git/commitdiff
bgpd: strncmp -> strcmp in community hash foo 10489/head
authorQuentin Young <qlyoung@nvidia.com>
Wed, 2 Feb 2022 21:34:03 +0000 (16:34 -0500)
committermergify-bot <noreply@mergify.com>
Thu, 3 Feb 2022 06:02:50 +0000 (06:02 +0000)
buffers are null terminated

Signed-off-by: Quentin Young <qlyoung@nvidia.com>
(cherry picked from commit c975f1a5e405f7a74d45519862388cd9ea8ce782)

bgpd/bgp_community_alias.c

index 793f3ac9ac1cf3bfaf5fa43c9b98b48af5c6a211..2c86efb5a0280248ccf4b05cc6a613eccb2de28d 100644 (file)
@@ -40,9 +40,7 @@ static bool bgp_ca_community_hash_cmp(const void *p1, const void *p2)
        const struct community_alias *ca1 = p1;
        const struct community_alias *ca2 = p2;
 
-       return (strncmp(ca1->community, ca2->community,
-                       sizeof(struct community_alias))
-               == 0);
+       return (strcmp(ca1->community, ca2->community) == 0);
 }
 
 static unsigned int bgp_ca_alias_hash_key(const void *p)
@@ -57,8 +55,7 @@ static bool bgp_ca_alias_hash_cmp(const void *p1, const void *p2)
        const struct community_alias *ca1 = p1;
        const struct community_alias *ca2 = p2;
 
-       return (strncmp(ca1->alias, ca2->alias, sizeof(struct community_alias))
-               == 0);
+       return (strcmp(ca1->alias, ca2->alias) == 0);
 }
 
 static void *bgp_community_alias_alloc(void *p)