]> git.puffer.fish Git - matthieu/frr.git/commitdiff
eigrpd: fix clang warning
authorVincent JARDIN <vincent.jardin@6wind.com>
Sun, 8 Oct 2017 22:06:08 +0000 (00:06 +0200)
committerVincent JARDIN <vincent.jardin@6wind.com>
Sun, 8 Oct 2017 22:06:08 +0000 (00:06 +0200)
nbr cannot be NULL. Doing such test does confuse clang since
we do not have execution case if nbr == NULL.

Signed-off-by: Vincent Jardin <vincent.jardin@6wind.com>
eigrpd/eigrp_packet.c

index 29d95f17b20b72b6470e1598206d367fbabe761b..83ff194729f592ab9a46d9150362e9c0b3a3ec85 100644 (file)
@@ -169,7 +169,7 @@ int eigrp_check_md5_digest(struct stream *s,
        struct TLV_MD5_Authentication_Type *auth_TLV;
        struct eigrp_header *eigrph;
 
-       if (nbr && ntohl(nbr->crypt_seqnum) > ntohl(authTLV->key_sequence)) {
+       if (ntohl(nbr->crypt_seqnum) > ntohl(authTLV->key_sequence)) {
                zlog_warn(
                        "interface %s: eigrp_check_md5 bad sequence %d (expect %d)",
                        IF_NAME(nbr->ei), ntohl(authTLV->key_sequence),