bgpd: Set the software version capability received flag only after a validation

We shouldn't set it blindly once the packet is received, but first we have to
do some sanity checks.

Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>

diff --git a/bgpd/bgp_open.c b/bgpd/bgp_open.c
index 545da7c559407cfac8be7fb3b02e46ecf745bdca..b9ab4018501da5f43459341059276cfa307d2816 100644 (file)
--- a/bgpd/bgp_open.c
+++ b/bgpd/bgp_open.c
@@ -896,8 +896,6 @@ static int bgp_capability_software_version(struct peer *peer,
        size_t end = stream_get_getp(s) + hdr->length;
        uint8_t len;
 
-       SET_FLAG(peer->cap, PEER_CAP_SOFT_VERSION_RCV);
-
        len = stream_getc(s);
        if (stream_get_getp(s) + len > end) {
                flog_warn(
@@ -907,6 +905,8 @@ static int bgp_capability_software_version(struct peer *peer,
                return -1;
        }
 
+       SET_FLAG(peer->cap, PEER_CAP_SOFT_VERSION_RCV);
+
        if (len > BGP_MAX_SOFT_VERSION) {
                flog_warn(EC_BGP_CAPABILITY_INVALID_LENGTH,
                          "%s: Received Software Version, but the length is too big, truncating, from peer %s",