2005-01-30 Andrew J. Schorr <ajschorr@alumni.princeton.edu>

	* daemon.c: (daemon) Replace perror with zlog_err.
	* vty.c: (vty_serv_un) Replace perror with zlog_err.
	* ripd.c: (rip_create_socket) Replace perror with zlog_err.
	* ioctl.c: (if_ioctl,if_ioctl_ipv6,if_get_flags) Replace perror with
	  zlog_err.
	* ioctl_solaris.c: (if_ioctl,if_ioctl_ipv6) Replace perror with
	  zlog_err.

diff --git a/lib/ChangeLog b/lib/ChangeLog
index 34dad166c4419a2caa9e89bc8395c122b58b9ff5..dcf37767f9afb7cee8bce0265573ae57b152fe55 100644 (file)
--- a/lib/ChangeLog
+++ b/lib/ChangeLog
@@ -1,3 +1,8 @@
+2005-01-30 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
+
+       * daemon.c: (daemon) Replace perror with zlog_err.
+       * vty.c: (vty_serv_un) Replace perror with zlog_err.
+
 2005-01-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
 
        * buffer.h: Fix comment on buffer_getstr to reflect that it now

diff --git a/lib/daemon.c b/lib/daemon.c
index d8380106d83862910374d2183ca47847166e8914..e73a74f10d59528e5bc511daa75eb5cc53d64ac8 100644 (file)
--- a/lib/daemon.c
+++ b/lib/daemon.c
@@ -35,7 +35,7 @@ daemon (int nochdir, int noclose)
   /* In case of fork is error. */
   if (pid < 0)
     {
-      perror ("fork");
+      zlog_err ("fork failed: %s", safe_strerror(errno));
       return -1;
     }
 
@@ -48,7 +48,7 @@ daemon (int nochdir, int noclose)
 
   if (pid == -1)
     {
-      perror ("setsid");
+      zlog_err ("setsid failed: %s", safe_strerror(errno));
       return -1;
     }
 

diff --git a/lib/vty.c b/lib/vty.c
index 42487330fafb67173bbbf65de2da7cbbe8e31e44..053e9ee84a948db58ef75856f1fda1cbc2bd7a39 100644 (file)
--- a/lib/vty.c
+++ b/lib/vty.c
@@ -1824,7 +1824,7 @@ vty_serv_un (const char *path)
   sock = socket (AF_UNIX, SOCK_STREAM, 0);
   if (sock < 0)
     {
-      perror ("sock");
+      zlog_err("Cannot create unix stream socket: %s", safe_strerror(errno));
       return;
     }
 
@@ -1841,7 +1841,7 @@ vty_serv_un (const char *path)
   ret = bind (sock, (struct sockaddr *) &serv, len);
   if (ret < 0)
     {
-      perror ("bind");
+      zlog_err("Cannot bind path %s: %s", path, safe_strerror(errno));
       close (sock);    /* Avoid sd leak. */
       return;
     }
@@ -1849,7 +1849,7 @@ vty_serv_un (const char *path)
   ret = listen (sock, 5);
   if (ret < 0)
     {
-      perror ("listen");
+      zlog_err("listen(fd %d) failed: %s", sock, safe_strerror(errno));
       close (sock);    /* Avoid sd leak. */
       return;
     }

diff --git a/ripd/ChangeLog b/ripd/ChangeLog
index 5a5d1b4b12a6473144ddf8a91a71c8e9e51007e2..60be27ea09e37e5bf63fd4602efa238d49a584c0 100644 (file)
--- a/ripd/ChangeLog
+++ b/ripd/ChangeLog
@@ -1,3 +1,7 @@
+2005-01-30 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
+
+       * ripd.c: (rip_create_socket) Replace perror with zlog_err.
+
 2005-01-30 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
 
        * ripd.c: (rip_create_socket) Save errno before calling

diff --git a/ripd/ripd.c b/ripd/ripd.c
index 2a345a667d9a228db6e2c533c2c9efc5737fc18a..b5d130e89aa5e0a51541c3647c8c9b646c96bcd5 100644 (file)
--- a/ripd/ripd.c
+++ b/ripd/ripd.c
@@ -1985,7 +1985,7 @@ rip_create_socket ()
   sock = socket (AF_INET, SOCK_DGRAM, 0);
   if (sock < 0) 
     {
-      perror ("socket");
+      zlog_err("Cannot create UDP socket: %s", safe_strerror(errno));
       exit (1);
     }
 

diff --git a/zebra/ChangeLog b/zebra/ChangeLog
index 0ebe7052c79821da97c37790e7663990a36f49cc..1f97fef9ac7d42968a595918e68e719a2e2c50d7 100644 (file)
--- a/zebra/ChangeLog
+++ b/zebra/ChangeLog
@@ -1,3 +1,10 @@
+2005-01-30 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
+
+       * ioctl.c: (if_ioctl,if_ioctl_ipv6,if_get_flags) Replace perror with
+         zlog_err.
+       * ioctl_solaris.c: (if_ioctl,if_ioctl_ipv6) Replace perror with
+         zlog_err.
+
 2005-01-29 Andrew J. Schorr <ajschorr@alumni.princeton.edu>
 
        * if_ioctl_solaris.c: (interface_list_ioctl) Save errno before calling

diff --git a/zebra/ioctl.c b/zebra/ioctl.c
index e28d359efb0b0ff3aab6898899b9ab89102bbca3..56de810c2b6778aa7249ffbf099ce4cc28260c19 100644 (file)
--- a/zebra/ioctl.c
+++ b/zebra/ioctl.c
@@ -54,9 +54,10 @@ if_ioctl (u_long request, caddr_t buffer)
   sock = socket (AF_INET, SOCK_DGRAM, 0);
   if (sock < 0)
     {
+      int save_errno = errno;
       if (zserv_privs.change(ZPRIVS_LOWER))
         zlog (NULL, LOG_ERR, "Can't lower privileges");
-      perror ("socket");
+      zlog_err("Cannot create UDP socket: %s", safe_strerror(save_errno));
       exit (1);
     }
   if ((ret = ioctl (sock, request, buffer)) < 0)
@@ -86,9 +87,11 @@ if_ioctl_ipv6 (u_long request, caddr_t buffer)
   sock = socket (AF_INET6, SOCK_DGRAM, 0);
   if (sock < 0)
     {
+      int save_errno = errno;
       if (zserv_privs.change(ZPRIVS_LOWER))
         zlog (NULL, LOG_ERR, "Can't lower privileges");
-      perror ("socket");
+      zlog_err("Cannot create IPv6 datagram socket: %s",
+              safe_strerror(save_errno));
       exit (1);
     }
 
@@ -343,7 +346,7 @@ if_get_flags (struct interface *ifp)
   ret = if_ioctl (SIOCGIFFLAGS, (caddr_t) &ifreq);
   if (ret < 0) 
     {
-      perror ("ioctl");
+      zlog_err("if_ioctl(SIOCGIFFLAGS) failed: %s", safe_strerror(errno));
       return;
     }
 

diff --git a/zebra/ioctl_solaris.c b/zebra/ioctl_solaris.c
index 5ec327acdcfafe28f1f865b13cace0a81b676900..43e1e83f9608402e559826c1c3ca53d3236ec187 100644 (file)
--- a/zebra/ioctl_solaris.c
+++ b/zebra/ioctl_solaris.c
@@ -55,9 +55,10 @@ if_ioctl (u_long request, caddr_t buffer)
   sock = socket (AF_INET, SOCK_DGRAM, 0);
   if (sock < 0)
     {
+      int save_errno = errno;
       if (zserv_privs.change(ZPRIVS_LOWER))
         zlog (NULL, LOG_ERR, "Can't lower privileges");
-      perror ("socket");
+      zlog_err("Cannot create UDP socket: %s", safe_strerror(save_errno));
       exit (1);
     }
 
@@ -92,9 +93,11 @@ if_ioctl_ipv6 (u_long request, caddr_t buffer)
   sock = socket (AF_INET6, SOCK_DGRAM, 0);
   if (sock < 0)
     {
+      int save_errno = errno;
       if (zserv_privs.change(ZPRIVS_LOWER))
         zlog (NULL, LOG_ERR, "Can't lower privileges");
-      perror ("socket");
+      zlog_err("Cannot create IPv6 datagram socket: %s",
+              safe_strerror(save_errno));
       exit (1);
     }