]> git.puffer.fish Git - mirror/frr.git/commitdiff
pbrd: address 230815 coverity: r.action.flags reordering
authorG. Paul Ziemba <paulz@labn.net>
Fri, 18 Aug 2023 18:11:17 +0000 (11:11 -0700)
committerG. Paul Ziemba <paulz@labn.net>
Fri, 18 Aug 2023 18:11:17 +0000 (11:11 -0700)
Signed-off-by: G. Paul Ziemba <paulz@labn.net>
pbrd/pbr_zebra.c

index 35c771469c1979508e48a2ecee9b6aee2cfe4fa7..ee17a193f46f8dfe968848b20b6e799f38cb07ee 100644 (file)
@@ -568,15 +568,10 @@ static bool pbr_encode_pbr_map_sequence(struct stream *s,
 
        /* actions */
 
-       SET_FLAG(r.action.flags, PBR_ACTION_TABLE); /* always valid */
-
-       /*
-        * PBR should maintain its own set of action flags that we
-        * can copy here instead of trying to infer from magic values.
-        */
-
        r.action.flags = pbrms->action_bm;
 
+       SET_FLAG(r.action.flags, PBR_ACTION_TABLE); /* always valid */
+
        /*
         * if the user does not use the command "set vrf name unchanged"
         * then pbr_encode_pbr_map_sequence_vrf will not be called