pimd: Prevent memory leak

When we decide that we do not need a item on the partial_bsrp_list
don't just drop the memory on the floor, free it up.

This was happening when we decided that a pending item has
a hold time of 0.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>

diff --git a/pimd/pim_bsm.c b/pimd/pim_bsm.c
index 0181e885fd6df721abc7ea1ae89662fe76138a1b..f2845ee6e12cd8ff99ba702173fc36c9b179a02a 100644 (file)
--- a/pimd/pim_bsm.c
+++ b/pimd/pim_bsm.c
@@ -419,9 +419,12 @@ static void pim_instate_pend_list(struct bsgrp_node *bsgrp_node)
        active = bsm_rpinfos_first(bsgrp_node->bsrp_list);
 
        /* Remove nodes with hold time 0 & check if list still has a head */
-       frr_each_safe (bsm_rpinfos, bsgrp_node->partial_bsrp_list, pend)
-               if (is_hold_time_zero(pend))
+       frr_each_safe (bsm_rpinfos, bsgrp_node->partial_bsrp_list, pend) {
+               if (is_hold_time_zero(pend)) {
                        bsm_rpinfos_del(bsgrp_node->partial_bsrp_list, pend);
+                       pim_bsm_rpinfo_free(pend);
+               }
+       }
 
        pend = bsm_rpinfos_first(bsgrp_node->partial_bsrp_list);