]> git.puffer.fish Git - mirror/frr.git/commitdiff
zebra: Ensure bvlan is non null
authorDonald Sharp <sharpd@nvidia.com>
Thu, 16 Feb 2023 14:06:59 +0000 (09:06 -0500)
committerDonald Sharp <sharpd@nvidia.com>
Thu, 16 Feb 2023 14:06:59 +0000 (09:06 -0500)
Coverity rightly points out that a call into zebra_l2_bridge_if_vlan_find
is NULL checked 4/5 times.  Let's make it 5/5

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
zebra/zebra_l2_bridge_if.c

index 65748999270850afa14cf1593bbde0b8014ac1de..b85d39bcd6d9c7e83e98cec59dd8e1a81ba4b242 100644 (file)
@@ -209,6 +209,8 @@ static int zebra_l2_bridge_if_vlan_update(struct interface *ifp,
 
        zif = (struct zebra_if *)ifp->info;
        bvlan = zebra_l2_bridge_if_vlan_find(zif, bvl->vid);
+       if (!bvlan)
+               return 0;
 
        if (chgflags & ZEBRA_BRIDGEIF_ACCESS_BD_CHANGE)
                bvlan->access_bd = bvl->access_bd;