bgpd: Convert rcvd_attr_printed to a bool

No need for a integer to store this, use a bool

Signed-off-by: Donald Sharp <sharpd@nvidia.com>

diff --git a/bgpd/bgp_packet.c b/bgpd/bgp_packet.c
index 0523a4b02b4ebf22140dc9f0793e9676d64e2a74..a76a300c11bccfcdefea343ab33d9cb979e4693c 100644 (file)
--- a/bgpd/bgp_packet.c
+++ b/bgpd/bgp_packet.c
@@ -2314,7 +2314,7 @@ static int bgp_update_receive(struct peer_connection *connection,
        attr.label = MPLS_INVALID_LABEL;
        memset(&nlris, 0, sizeof(nlris));
        memset(peer->rcvd_attr_str, 0, BUFSIZ);
-       peer->rcvd_attr_printed = 0;
+       peer->rcvd_attr_printed = false;
 
        s = peer->curr;
        end = stream_pnt(s) + size;
@@ -2422,7 +2422,7 @@ static int bgp_update_receive(struct peer_connection *connection,
                    BGP_DEBUG(update, UPDATE_DETAIL)) {
                        zlog_debug("%pBP rcvd UPDATE w/ attr: %s", peer,
                                   peer->rcvd_attr_str);
-                       peer->rcvd_attr_printed = 1;
+                       peer->rcvd_attr_printed = true;
                }
        }
 

diff --git a/bgpd/bgp_route.c b/bgpd/bgp_route.c
index b5ef7bd0768c65247c6f05664e18c2c213b42f9c..f07a8730c8df75ec20e6c1082c4be2edd2c9dce6 100644 (file)
--- a/bgpd/bgp_route.c
+++ b/bgpd/bgp_route.c
@@ -5063,7 +5063,7 @@ void bgp_update(struct peer *peer, const struct prefix *p, uint32_t addpath_id,
                                                        "%pBP rcvd UPDATE w/ attr: %s",
                                                        peer,
                                                        peer->rcvd_attr_str);
-                                               peer->rcvd_attr_printed = 1;
+                                               peer->rcvd_attr_printed = true;
                                        }
 
                                        bgp_debug_rdpfxpath2str(
@@ -5346,7 +5346,7 @@ void bgp_update(struct peer *peer, const struct prefix *p, uint32_t addpath_id,
                if (!peer->rcvd_attr_printed) {
                        zlog_debug("%pBP rcvd UPDATE w/ attr: %s", peer,
                                   peer->rcvd_attr_str);
-                       peer->rcvd_attr_printed = 1;
+                       peer->rcvd_attr_printed = true;
                }
 
                bgp_debug_rdpfxpath2str(afi, safi, prd, p, label, num_labels,
@@ -5450,7 +5450,7 @@ filtered:
                if (!peer->rcvd_attr_printed) {
                        zlog_debug("%pBP rcvd UPDATE w/ attr: %s", peer,
                                   peer->rcvd_attr_str);
-                       peer->rcvd_attr_printed = 1;
+                       peer->rcvd_attr_printed = true;
                }
 
                bgp_debug_rdpfxpath2str(afi, safi, prd, p, label, num_labels,

diff --git a/bgpd/bgpd.h b/bgpd/bgpd.h
index f37a722f0c43bdff23223a409ab0b114241844f5..f7f74c670f08d6d769061ded68d81713365cce38 100644 (file)
--- a/bgpd/bgpd.h
+++ b/bgpd/bgpd.h
@@ -1769,8 +1769,15 @@ struct peer {
        /* Text description of last attribute rcvd */
        char rcvd_attr_str[BUFSIZ];
 
-       /* Track if we printed the attribute in debugs */
-       int rcvd_attr_printed;
+       /*
+        * Track if we printed the attribute in debugs
+        *
+        * These two rcvd_attr_str and rcvd_attr_printed are going to
+        * be fun in the long term when we want to break up parsing
+        * of data from the nlri in multiple pthreads or really
+        * if we ever change order of things this will just break
+        */
+       bool rcvd_attr_printed;
 
        /* Accepted prefix count */
        uint32_t pcount[AFI_MAX][SAFI_MAX];