[bgpd] CID#62 fix double-free, use-after-free in community_str2com

2006-05-08 Paul Jakma <paul.jakma@sun.com>

	* bgp_community.c: (community_str2com) Coverity CID#62, fix
	  double-free, use-after-free.

diff --git a/bgpd/ChangeLog b/bgpd/ChangeLog
index 5599801e681d444251bcc9f58dee81df5c898109..16a56fc2b94bc30d644b10559c150410ec596527 100644 (file)
--- a/bgpd/ChangeLog
+++ b/bgpd/ChangeLog
@@ -1,3 +1,8 @@
+2006-05-08 Paul Jakma <paul.jakma@sun.com>
+
+       * bgp_community.c: (community_str2com) Coverity CID#62, fix
+         double-free, use-after-free.
+
 2006-05-04 Paul Jakma <paul.jakma@sun.com>
 
        * (general) VPNv4 fixes. Certain VPNv4 code was not enabled.

diff --git a/bgpd/bgp_community.c b/bgpd/bgp_community.c
index b419a203b74a209fa586c5bc46aed40fb6adada0..07b8cf81f8545ceb32a8064da5fbd5b06e6224d4 100644 (file)
--- a/bgpd/bgp_community.c
+++ b/bgpd/bgp_community.c
@@ -596,7 +596,7 @@ community_str2com (const char *str)
        default:
          if (com)
            community_free (com);
-         break;
+         return NULL;
        }
     } while (str);