bgpd: Remove unneeded loop over all peers

The bgp_notify_conditional_adv_scanner function was/is looping
over all peers.  And only matching on the passed in peer,
based upon the subgroup.  As such we do not need to loop
over everything and just cut-to-the chase and just modify
the peer structure.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>

diff --git a/bgpd/bgp_route.c b/bgpd/bgp_route.c
index 3836d5f24bc16e13a0e7d3a14db3391dfdf3de2d..5318ee28ee854929322e2229a61d8c0d5a6f9be5 100644 (file)
--- a/bgpd/bgp_route.c
+++ b/bgpd/bgp_route.c
@@ -1803,27 +1803,18 @@ void bgp_attr_add_gshut_community(struct attr *attr)
 /* Notify BGP Conditional advertisement scanner process. */
 void bgp_notify_conditional_adv_scanner(struct update_subgroup *subgrp)
 {
-       struct peer *temp_peer;
        struct peer *peer = SUBGRP_PEER(subgrp);
-       struct listnode *temp_node, *temp_nnode = NULL;
        afi_t afi = SUBGRP_AFI(subgrp);
        safi_t safi = SUBGRP_SAFI(subgrp);
-       struct bgp *bgp = SUBGRP_INST(subgrp);
        struct bgp_filter *filter = &peer->filter[afi][safi];
 
        if (!ADVERTISE_MAP_NAME(filter))
                return;
 
-       for (ALL_LIST_ELEMENTS(bgp->peer, temp_node, temp_nnode, temp_peer)) {
-               if (!CHECK_FLAG(peer->flags, PEER_FLAG_CONFIG_NODE))
-                       continue;
-
-               if (peer != temp_peer)
-                       continue;
+       if (!CHECK_FLAG(peer->flags, PEER_FLAG_CONFIG_NODE))
+               return;
 
-               temp_peer->advmap_table_change = true;
-               break;
-       }
+       peer->advmap_table_change = true;
 }