]> git.puffer.fish Git - matthieu/frr.git/commitdiff
tests: Remove unneeded calls to addKernelRoutes
authorDonald Sharp <sharpd@nvidia.com>
Tue, 7 Sep 2021 20:51:27 +0000 (16:51 -0400)
committerDonald Sharp <sharpd@nvidia.com>
Wed, 8 Sep 2021 11:53:04 +0000 (07:53 -0400)
There is no need to add calls to addKernelRoutes for
groups.  They do not need to be routed via the
normal kernel methodology.

Tests run successfully with this change.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
tests/topotests/multicast_pim_bsm_topo1/test_mcast_pim_bsmp_01.py

index f1b13cbd025d5454d9198cecb36ad3fd8db8eda8..a94dcb505a8f3acb4edbe9997b3dd203d657064a 100644 (file)
@@ -306,12 +306,6 @@ def pre_config_to_bsm(tgen, topo, tc_name, bsr, sender, receiver, fhr, rp, lhr,
         result = create_static_routes(tgen, input_dict)
         assert result is True, "Testcase {} :Failed \n Error {}".format(tc_name, result)
 
-    # Add kernal route for source
-    group = topo["routers"][bsr]["bsm"]["bsr_packets"][packet]["pkt_dst"]
-    bsr_interface = topo["routers"][bsr]["links"][fhr]["interface"]
-    result = addKernelRoute(tgen, bsr, bsr_interface, group)
-    assert result is True, "Testcase {} :Failed \n Error {}".format(tc_name, result)
-
     # RP Mapping
     rp_mapping = topo["routers"][bsr]["bsm"]["bsr_packets"][packet]["rp_mapping"]
 
@@ -325,16 +319,6 @@ def pre_config_to_bsm(tgen, topo, tc_name, bsr, sender, receiver, fhr, rp, lhr,
         if int(mask) == 32:
             group = group.split("/")[0]
 
-        # Add kernal routes for sender
-        s_interface = topo["routers"][sender]["links"][fhr]["interface"]
-        result = addKernelRoute(tgen, sender, s_interface, group)
-        assert result is True, "Testcase {} :Failed \n Error {}".format(tc_name, result)
-
-        # Add kernal routes for receiver
-        r_interface = topo["routers"][receiver]["links"][lhr]["interface"]
-        result = addKernelRoute(tgen, receiver, r_interface, group)
-        assert result is True, "Testcase {} :Failed \n Error {}".format(tc_name, result)
-
         # Add static routes for RPs in FHR and LHR
         next_hop_fhr = topo["routers"][rp]["links"][fhr]["ipv4"].split("/")[0]
         next_hop_lhr = topo["routers"][rp]["links"][lhr]["ipv4"].split("/")[0]