]> git.puffer.fish Git - matthieu/frr.git/commitdiff
bgpd: Use interface name instead of pointer value
authorDonald Sharp <sharpd@nvidia.com>
Thu, 16 Mar 2023 14:24:25 +0000 (10:24 -0400)
committerDonald Sharp <sharpd@nvidia.com>
Thu, 16 Mar 2023 14:26:01 +0000 (10:26 -0400)
Log message is borked in a manner that makes it unusable:
bgpd[52]: [VX6SM-8YE5W][EC 33554460] 2000:31:0:53::2: nexthop_set failed, resetting connection - intf 0x561eb9005a30

Let's print out the interface name instead.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
bgpd/bgp_network.c

index 1c2e686e1c87c0f583027bf63a7f05c836d67824..6f035358f1c6e9c1a48de07f507e9dc33997a06d 100644 (file)
@@ -805,9 +805,12 @@ int bgp_getsockname(struct peer *peer)
 
        if (!bgp_zebra_nexthop_set(peer->su_local, peer->su_remote,
                                   &peer->nexthop, peer)) {
-               flog_err(EC_BGP_NH_UPD,
-                        "%s: nexthop_set failed, resetting connection - intf %p",
-                        peer->host, peer->nexthop.ifp);
+               flog_err(
+                       EC_BGP_NH_UPD,
+                       "%s: nexthop_set failed, resetting connection - intf %s",
+                       peer->host,
+                       peer->nexthop.ifp ? peer->nexthop.ifp->name
+                                         : "(Unknown)");
                return -1;
        }
        return 0;