bgpd: Prevent use after free from coverity's perspective

Prevent a use after free from coverity's perspective.  A
bgp node may have been freed.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>

diff --git a/bgpd/bgp_mplsvpn.c b/bgpd/bgp_mplsvpn.c
index 9b5d56863619720685e725c2abba0024328672b0..00930dea6b8f4dd44d627d71f82e727d916b65ee 100644 (file)
--- a/bgpd/bgp_mplsvpn.c
+++ b/bgpd/bgp_mplsvpn.c
@@ -1179,12 +1179,13 @@ leak_update(struct bgp *to_bgp, struct bgp_dest *bn,
                /* Process change. */
                bgp_aggregate_increment(to_bgp, p, bpi, afi, safi);
                bgp_process(to_bgp, bn, afi, safi);
-               bgp_dest_unlock_node(bn);
 
                if (debug)
                        zlog_debug("%s: ->%s: %pBD Found route, changed attr",
                                   __func__, to_bgp->name_pretty, bn);
 
+               bgp_dest_unlock_node(bn);
+
                return bpi;
        }