bgpd: Remove redundant check for bgp against NULL

bgp_orig is never NULL in the code path, and coverity is angry on this.

Let's remove this test at all.

Coverity 1566808

Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>

diff --git a/bgpd/bgp_mplsvpn.c b/bgpd/bgp_mplsvpn.c
index 138b182718e2035a0a6e01e058668dac24cfb9e7..c3e870ee9d55bda1166a70d2fa5401c6cd419055 100644 (file)
--- a/bgpd/bgp_mplsvpn.c
+++ b/bgpd/bgp_mplsvpn.c
@@ -1225,8 +1225,9 @@ leak_update(struct bgp *to_bgp, struct bgp_dest *bn,
        new->extra->vrfleak->parent = bgp_path_info_lock(parent);
        bgp_dest_lock_node(
                (struct bgp_dest *)parent->net);
-       if (bgp_orig)
-               new->extra->vrfleak->bgp_orig = bgp_lock(bgp_orig);
+
+       new->extra->vrfleak->bgp_orig = bgp_lock(bgp_orig);
+
        if (nexthop_orig)
                new->extra->vrfleak->nexthop_orig = *nexthop_orig;