]> git.puffer.fish Git - matthieu/frr.git/commitdiff
pimd: All paths have already derefed pim->global_scope.bsrp_table
authorDonald Sharp <sharpd@cumulusnetworks.com>
Fri, 25 Oct 2019 11:05:11 +0000 (07:05 -0400)
committerDonald Sharp <sharpd@cumulusnetworks.com>
Fri, 25 Oct 2019 11:05:11 +0000 (07:05 -0400)
All paths leading to this point in the code have already deref'ed
the pim->global_scope.bsrp_table.  No point in testing for
validness now.  This was caught by Coverity.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
pimd/pim_bsm.c

index 9d42666b92da587a2ae80444e61db143a98808bc..1383e3db116e41933e46b47f1b65c95917ae7d2f 100644 (file)
@@ -290,8 +290,7 @@ void pim_bsm_proc_free(struct pim_instance *pim)
                pim_free_bsgrp_data(bsgrp);
        }
 
-       if (pim->global_scope.bsrp_table)
-               route_table_finish(pim->global_scope.bsrp_table);
+       route_table_finish(pim->global_scope.bsrp_table);
 }
 
 static bool is_hold_time_elapsed(void *data)