]> git.puffer.fish Git - mirror/frr.git/commitdiff
bfdd zebra: dead code (Coverity 1472624 1473199) 3095/head
authorF. Aragon <paco@voltanet.io>
Wed, 26 Sep 2018 15:50:33 +0000 (17:50 +0200)
committerF. Aragon <paco@voltanet.io>
Wed, 26 Sep 2018 15:50:33 +0000 (17:50 +0200)
Signed-off-by: F. Aragon <paco@voltanet.io>
bfdd/bfdd_vty.c
zebra/zebra_vxlan.c

index 1c6d03195c8a5754f99fe9f5a4f63e38357bb220..51dd9cb26da77fb153208abca29839fa76043ac2 100644 (file)
@@ -886,14 +886,7 @@ static int bfd_configure_peer(struct bfd_peer_cfg *bpc, bool mhop,
        if (local)
                bpc->bpc_local = *local;
 
-       if (peer) {
-               bpc->bpc_peer = *peer;
-       } else {
-               /* Peer configuration is mandatory. */
-               snprintf(ebuf, ebuflen, "no peer configured");
-               return -1;
-       }
-
+       bpc->bpc_peer = *peer;
        bpc->bpc_mhop = mhop;
 
        /* Handle interface specification configuration. */
index ea0bef37183b841569bd7588714cf9a566678be8..989d63f9b1ff58ab56c02ae6d4abef522f899064 100644 (file)
@@ -4269,10 +4269,8 @@ static void process_remote_macip_add(vni_t vni,
                                        vni,
                                        prefix_mac2str(macaddr,
                                                       buf, sizeof(buf)),
-                                       ipa_len ? " IP " : "",
-                                       ipa_len ?
-                                       ipaddr2str(ipaddr,
-                                                  buf1, sizeof(buf1)) : "",
+                                       " IP ",
+                                       ipaddr2str(ipaddr, buf1, sizeof(buf1)),
                                        n_type,
                                        tmp_seq);
                                return;