]> git.puffer.fish Git - mirror/frr.git/commitdiff
isisd: Fix run level for spf_run_count
authorDonald Sharp <sharpd@nvidia.com>
Tue, 29 Apr 2025 13:34:06 +0000 (09:34 -0400)
committerDonald Sharp <sharpd@nvidia.com>
Tue, 29 Apr 2025 13:34:06 +0000 (09:34 -0400)
Running isis with undefined behavior compiled in gives you this
warning:

isisd/isis_spf.c:2126:22: runtime error: index 2 out of bounds for type '_uint64_t [2]'

Looking at the rest of isis this should be level-1 because the
declaration for spf_run_count only has 2 levels.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
isisd/isis_spf.c

index 5960fef7553b3bee953f847b4501ed4e4df83291..48d7da4a9210d27b9b34f68cbc56278bef330c94 100644 (file)
@@ -2123,7 +2123,7 @@ static void isis_run_spf_cb(struct event *thread)
        }
 
        if (have_run)
-               area->spf_run_count[level]++;
+               area->spf_run_count[level - 1]++;
 
        isis_area_verify_routes(area);