]> git.puffer.fish Git - mirror/frr.git/commitdiff
topogen: fix assertion on `routers_have_failure`
authorRafael Zalamena <rzalamena@opensourcerouting.org>
Fri, 22 Dec 2017 14:19:09 +0000 (12:19 -0200)
committerDonald Sharp <sharpd@cumulusnetworks.com>
Wed, 28 Nov 2018 01:22:13 +0000 (20:22 -0500)
`errors != ''` is never going to be false so the assert was never being
triggered.

Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
tests/topotests/lib/topogen.py

index 116dd9a41e6bc2c1f1e9aff067e820216b0c132f..5c6e9af8adf0c7bba05d147da49edeac6686fc59 100644 (file)
@@ -386,7 +386,7 @@ class Topogen(object):
 
         if errors != '':
             self.set_error(errors, 'router_error')
-            assert errors != '', errors
+            assert False, errors
             return True
         return False