eigrpd: Tone down warning when command is not implemented yet

Currently eigrp has a bunch of commands that are not fully
implemented yet.  Tone down the yang code change of making
these in your face errors to zlog_warns, so the end-user
can not be freaked out by the message.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>

diff --git a/eigrpd/eigrp_northbound.c b/eigrpd/eigrp_northbound.c
index 13887368f72c6ed09f325af2443b063efe803ab1..5b87f7264016c37d382c4a6cb328a12d4f69e5c1 100644 (file)
--- a/eigrpd/eigrp_northbound.c
+++ b/eigrpd/eigrp_northbound.c
@@ -243,10 +243,12 @@ static int eigrpd_instance_active_time_modify(struct nb_cb_modify_args *args)
        switch (args->event) {
        case NB_EV_VALIDATE:
                /* TODO: Not implemented. */
-               return NB_ERR_INCONSISTENCY;
        case NB_EV_PREPARE:
        case NB_EV_ABORT:
+               return NB_OK;
        case NB_EV_APPLY:
+               snprintf(args->errmsg, args->errmsg_len,
+                        "active time not implemented yet");
                /* NOTHING */
                break;
        }
@@ -677,11 +679,12 @@ static int eigrpd_instance_neighbor_create(struct nb_cb_create_args *args)
        switch (args->event) {
        case NB_EV_VALIDATE:
                /* TODO: Not implemented. */
-               return NB_ERR_INCONSISTENCY;
        case NB_EV_PREPARE:
        case NB_EV_ABORT:
+               return NB_OK;
        case NB_EV_APPLY:
-               /* NOTHING */
+               snprintf(args->errmsg, args->errmsg_len,
+                        "neighbor Command is not implemented yet");
                break;
        }
 
@@ -693,11 +696,12 @@ static int eigrpd_instance_neighbor_destroy(struct nb_cb_destroy_args *args)
        switch (args->event) {
        case NB_EV_VALIDATE:
                /* TODO: Not implemented. */
-               return NB_ERR_INCONSISTENCY;
        case NB_EV_PREPARE:
        case NB_EV_ABORT:
+               return NB_OK;
        case NB_EV_APPLY:
-               /* NOTHING */
+               snprintf(args->errmsg, args->errmsg_len,
+                        "no neighbor Command is not implemented yet");
                break;
        }
 
@@ -768,11 +772,13 @@ eigrpd_instance_redistribute_route_map_modify(struct nb_cb_modify_args *args)
        switch (args->event) {
        case NB_EV_VALIDATE:
                /* TODO: Not implemented. */
-               return NB_ERR_INCONSISTENCY;
        case NB_EV_PREPARE:
        case NB_EV_ABORT:
+               return NB_OK;
        case NB_EV_APPLY:
-               /* NOTHING */
+               snprintf(
+                       args->errmsg, args->errmsg_len,
+                       "'redistribute X route-map FOO' command not implemented yet");
                break;
        }
 
@@ -785,11 +791,13 @@ eigrpd_instance_redistribute_route_map_destroy(struct nb_cb_destroy_args *args)
        switch (args->event) {
        case NB_EV_VALIDATE:
                /* TODO: Not implemented. */
-               return NB_ERR_INCONSISTENCY;
        case NB_EV_PREPARE:
        case NB_EV_ABORT:
+               return NB_OK;
        case NB_EV_APPLY:
-               /* NOTHING */
+               snprintf(
+                       args->errmsg, args->errmsg_len,
+                       "'no redistribute X route-map FOO' command not implemented yet");
                break;
        }
 
@@ -1079,10 +1087,12 @@ lib_interface_eigrp_split_horizon_modify(struct nb_cb_modify_args *args)
        switch (args->event) {
        case NB_EV_VALIDATE:
                /* TODO: Not implemented. */
-               return NB_ERR_INCONSISTENCY;
        case NB_EV_PREPARE:
        case NB_EV_ABORT:
+               return NB_OK;
        case NB_EV_APPLY:
+               snprintf(args->errmsg, args->errmsg_len,
+                        "split-horizon command not implemented yet");
                /* NOTHING */
                break;
        }
@@ -1161,11 +1171,12 @@ static int lib_interface_eigrp_instance_summarize_addresses_create(
        switch (args->event) {
        case NB_EV_VALIDATE:
                /* TODO: Not implemented. */
-               return NB_ERR_INCONSISTENCY;
        case NB_EV_PREPARE:
        case NB_EV_ABORT:
+               return NB_OK;
        case NB_EV_APPLY:
-               /* NOTHING */
+               snprintf(args->errmsg, args->errmsg_len,
+                        "summary command not implemented yet");
                break;
        }
 
@@ -1178,10 +1189,12 @@ static int lib_interface_eigrp_instance_summarize_addresses_destroy(
        switch (args->event) {
        case NB_EV_VALIDATE:
                /* TODO: Not implemented. */
-               return NB_ERR_INCONSISTENCY;
        case NB_EV_PREPARE:
        case NB_EV_ABORT:
+               return NB_OK;
        case NB_EV_APPLY:
+               snprintf(args->errmsg, args->errmsg_len,
+                        "no summary command not implemented yet");
                /* NOTHING */
                break;
        }