isisd: resolve possible null pointer dereference

issue found by cppcheck

[isisd/dict.c:1320] -> [isisd/dict.c:1065]:
(warning) Either the condition '!dn' is redundant or
there is possible null pointer dereference: newnode.

[isisd/dict.c:1320] -> [isisd/dict.c:1068]:
(warning) Either the condition '!dn' is redundant or
there is possible null pointer dereference: newnode.

Signed-off-by: Ilya Shipitsin <chipitsine@gmail.com>
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

diff --git a/isisd/dict.c b/isisd/dict.c
index 2ea86d1b68bdb80655f4b450bd086cb0c831e74d..20a4c0ff7383fe31d7199482ff186d797b2bf2e1 100644 (file)
--- a/isisd/dict.c
+++ b/isisd/dict.c
@@ -1323,9 +1323,8 @@ static void construct(dict_t *d)
                                free(val);
                                if (dn)
                                        dnode_destroy(dn);
-                       }
-
-                       dict_load_next(&dl, dn, key);
+                       } else
+                               dict_load_next(&dl, dn, key);
                        break;
                default:
                        putchar('?');