lib: fix a64448ba, invalid NULL->num_labels

We should assume match OK only when neither nhl1
and neither nhl2 are NULL.
If both are NULL, it means match NOK.

Clang Warning:
  Access to field 'num_labels' results in a dereference of a null
  pointer (loaded from variable 'nhl1')

Signed-off-by: Vincent Jardin <vincent.jardin@6wind.com>

diff --git a/lib/nexthop.c b/lib/nexthop.c
index ea6a310a4a139ac554a45d19ef392dc5bee61340..f6b2c9788d50a4757649f76d12b593ad821cbcbb 100644 (file)
--- a/lib/nexthop.c
+++ b/lib/nexthop.c
@@ -128,7 +128,7 @@ int nexthop_labels_match(struct nexthop *nh1, struct nexthop *nh2)
 
        nhl1 = nh1->nh_label;
        nhl2 = nh2->nh_label;
-       if ((nhl1 && !nhl2) || (!nhl1 && nhl2))
+       if (!nhl1 || !nhl2)
                return 0;
 
        if (nhl1->num_labels != nhl2->num_labels)