]> git.puffer.fish Git - mirror/frr.git/commitdiff
bgpd: data is set but never used
authorDonald Sharp <sharpd@nvidia.com>
Fri, 5 Jan 2024 18:02:16 +0000 (13:02 -0500)
committerDonald Sharp <sharpd@nvidia.com>
Tue, 9 Jan 2024 18:03:43 +0000 (13:03 -0500)
I've kept the assignment in a comment because I am concerned
about new code being added later that the data pointer would
not be set correctly.  Next coder can see the commented
out line and uncomment it.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
bgpd/bgp_packet.c

index ca8dade8e8b87b08707a54fcdae79ea2424aae80..f94b64d0bda4c448d17b20cee8b768297da6d786 100644 (file)
@@ -3349,7 +3349,7 @@ static void bgp_dynamic_capability_fqdn(uint8_t *pnt, int action,
                        memcpy(&str, data, len);
                        str[len] = '\0';
                }
-               data += len;
+               /* data += len;  In case new code is ever added */
 
                if (len) {
                        XFREE(MTYPE_BGP_PEER_HOST, peer->domainname);