]> git.puffer.fish Git - mirror/frr.git/commitdiff
bgpd: Remove a deadcode freeing JSON in bgp_show_all_instances_neighbors_vty 7001/head
authorDonatas Abraitis <donatas.abraitis@gmail.com>
Wed, 26 Aug 2020 05:46:28 +0000 (08:46 +0300)
committerDonatas Abraitis <donatas.abraitis@gmail.com>
Wed, 26 Aug 2020 05:46:28 +0000 (08:46 +0300)
json = NULL; is set in a loop above and here we are trying to check and
free the object again which is never be reached.

Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>
bgpd/bgp_vty.c

index 1c7727dd0b73a42cb1f3d6567697803452d6bf79..dfa812357fa894eeb5ebc1f019acb2c8fb4aeafc 100644 (file)
@@ -12800,11 +12800,8 @@ static void bgp_show_all_instances_neighbors_vty(struct vty *vty,
                json = NULL;
        }
 
-       if (use_json) {
+       if (use_json)
                vty_out(vty, "}\n");
-               if (json)
-                       json_object_free(json);
-       }
        else if (!nbr_output)
                vty_out(vty, "%% BGP instance not found\n");
 }