pbrd: initialize structs used in hash_lookup

Doesn't seem to break anything but really poor style to pass potentially
uninitialized data to hash_lookup.

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>
(cherry picked from commit c88589f5e9351654c04322eb395003297656989d)

diff --git a/pbrd/pbr_nht.c b/pbrd/pbr_nht.c
index ff252f8505349d0d03384945187ba81a9ed97d73..d5cee5f3e4eec417631bfb14338bf3aae0dffdf2 100644 (file)
--- a/pbrd/pbr_nht.c
+++ b/pbrd/pbr_nht.c
@@ -493,7 +493,7 @@ void pbr_nht_change_group(const char *name)
        }
 
        for (ALL_NEXTHOPS(nhgc->nhg, nhop)) {
-               struct pbr_nexthop_cache lookup;
+               struct pbr_nexthop_cache lookup = {};
                struct pbr_nexthop_cache *pnhc;
 
                lookup.nexthop = *nhop;
@@ -565,7 +565,7 @@ void pbr_nht_add_individual_nexthop(struct pbr_map_sequence *pbrms,
        struct pbr_nexthop_group_cache *pnhgc;
        struct pbr_nexthop_group_cache find;
        struct pbr_nexthop_cache *pnhc;
-       struct pbr_nexthop_cache lookup;
+       struct pbr_nexthop_cache lookup = {};
        struct nexthop *nh;
        char buf[PBR_NHC_NAMELEN];
 
@@ -624,7 +624,7 @@ static void pbr_nht_release_individual_nexthop(struct pbr_map_sequence *pbrms)
        struct pbr_nexthop_group_cache *pnhgc;
        struct pbr_nexthop_group_cache find;
        struct pbr_nexthop_cache *pnhc;
-       struct pbr_nexthop_cache lup;
+       struct pbr_nexthop_cache lup = {};
        struct nexthop *nh;
        enum nexthop_types_t nh_type = 0;
 
@@ -690,7 +690,7 @@ struct pbr_nexthop_group_cache *pbr_nht_add_group(const char *name)
        DEBUGD(&pbr_dbg_nht, "%s: Retrieved NHGC @ %p", __func__, pnhgc);
 
        for (ALL_NEXTHOPS(nhgc->nhg, nhop)) {
-               struct pbr_nexthop_cache lookupc;
+               struct pbr_nexthop_cache lookupc = {};
                struct pbr_nexthop_cache *pnhc;
 
                lookupc.nexthop = *nhop;

diff --git a/pbrd/pbr_vty.c b/pbrd/pbr_vty.c
index 08fe56c7bb3e9c26d6a07018597ef275ac2f02aa..aa9891357114a6befb83a9a881ba30df01498ca0 100644 (file)
--- a/pbrd/pbr_vty.c
+++ b/pbrd/pbr_vty.c
@@ -1488,7 +1488,7 @@ pbrms_nexthop_group_write_individual_nexthop(
 {
        struct pbr_nexthop_group_cache find;
        struct pbr_nexthop_group_cache *pnhgc;
-       struct pbr_nexthop_cache lookup;
+       struct pbr_nexthop_cache lookup = {};
        struct pbr_nexthop_cache *pnhc;
 
        memset(&find, 0, sizeof(find));