bgpd: fix oopsie with SendHoldTime==0

... *duh*

Signed-off-by: David Lamparter <equinox@opensourcerouting.org>

diff --git a/bgpd/bgp_packet.c b/bgpd/bgp_packet.c
index e4697fdb2bd45cb94f49f112af4d7ca18b47310b..c8996ba634e0a1ee26a24d0bd38ebd8ad24132cb 100644 (file)
--- a/bgpd/bgp_packet.c
+++ b/bgpd/bgp_packet.c
@@ -147,7 +147,9 @@ static void bgp_packet_add(struct peer *peer, struct stream *s)
                 * timer that ticks down SendHoldTime, as we'll be here sooner
                 * or later anyway and will see the checks below failing.
                 */
-               if (delta > 2 * (intmax_t)holdtime) {
+               if (!holdtime) {
+                       /* no holdtime, do nothing. */
+               } else if (delta > 2 * (intmax_t)holdtime) {
                        flog_err(
                                EC_BGP_SENDQ_STUCK_PROPER,
                                "%s has not made any SendQ progress for 2 holdtimes, terminating session",