bgpd: Avoid double aspath_dup() for confederation when remote-as != AS_SPECIFIED

Just was blind when not seing it's already dup'ed above:

```	if (peer->sort == BGP_PEER_EBGP
	    && (!CHECK_FLAG(peer->af_flags[afi][safi],
			    PEER_FLAG_AS_PATH_UNCHANGED)
		|| attr->aspath->segments == NULL)
	    && (!CHECK_FLAG(peer->af_flags[afi][safi],
			    PEER_FLAG_RSERVER_CLIENT))) {
		aspath = aspath_dup(attr->aspath); <<<<<<<<<<<<<<<
```

Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
(cherry picked from commit 9930441c66131d26fd7c51d9684b9e6a228c38d7)

diff --git a/bgpd/bgp_attr.c b/bgpd/bgp_attr.c
index 00a194f5c6e9ac08c7d4ee96f64a68453acac3fb..8e66a229c3c1b4f3f23432e56f027a3269413e57 100644 (file)
--- a/bgpd/bgp_attr.c
+++ b/bgpd/bgp_attr.c
@@ -4364,7 +4364,6 @@ bgp_size_t bgp_packet_attribute(struct bgp *bgp, struct peer *peer,
                         * if the peer belongs to us.
                         */
                        if (bgp_confederation_peers_check(bgp, peer->as)) {
-                               aspath = aspath_dup(attr->aspath);
                                aspath = aspath_add_confed_seq(aspath,
                                                               peer->local_as);
                        } else {