]> git.puffer.fish Git - matthieu/frr.git/commitdiff
bgpd: Prevent asn dot memory leak
authorDonald Sharp <sharpd@nvidia.com>
Sat, 25 Feb 2023 12:43:30 +0000 (07:43 -0500)
committerDonald Sharp <sharpd@nvidia.com>
Sat, 25 Feb 2023 12:43:30 +0000 (07:43 -0500)
When allocating a new bit of memory free the old first.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
bgpd/bgpd.c

index f97004dc1278bf06df91450574b812a490fe847d..96c6a111ce3b3e1cf30421c08acc639900f83510 100644 (file)
@@ -6313,8 +6313,11 @@ int peer_local_as_set(struct peer *peer, as_t as, bool no_prepend,
            && old_replace_as == replace_as)
                return 0;
        peer->change_local_as = as;
-       if (as_str)
+       if (as_str) {
+               if (peer->change_local_as_pretty)
+                       XFREE(MTYPE_BGP, peer->change_local_as_pretty);
                peer->change_local_as_pretty = XSTRDUP(MTYPE_BGP, as_str);
+       }
 
        (void)peer_sort(peer);