]> git.puffer.fish Git - mirror/frr.git/commitdiff
pim6d: fix coverity scan warning 17455/head
authorRafael Zalamena <rzalamena@opensourcerouting.org>
Mon, 18 Nov 2024 12:17:32 +0000 (09:17 -0300)
committerRafael Zalamena <rzalamena@opensourcerouting.org>
Mon, 18 Nov 2024 12:17:32 +0000 (09:17 -0300)
Fix Coverity Scan CID 1601875: use the return value to tell user about
the availability of a next hop to the learned RP (needs debug enabled).

Signed-off-by: Rafael Zalamena <rzalamena@opensourcerouting.org>
pimd/pim_rp.c

index 53d2a2d62e82d29c39039849a8f65ca36603c594..e6de991a1435bbeab45f5e227adbec6df30a19a7 100644 (file)
@@ -1541,8 +1541,12 @@ void pim_embedded_rp_new(struct pim_instance *pim, const pim_addr *group, const
                           &rp_info->rp.rpf_addr, &rp_info->group);
 
        pim_find_or_track_nexthop(pim, rp_info->rp.rpf_addr, NULL, rp_info, NULL);
-       pim_ecmp_nexthop_lookup(pim, &rp_info->rp.source_nexthop, rp_info->rp.rpf_addr,
-                               &rp_info->group, 1);
+       if (!pim_ecmp_nexthop_lookup(pim, &rp_info->rp.source_nexthop, rp_info->rp.rpf_addr,
+                                    &rp_info->group, 1)) {
+               if (PIM_DEBUG_PIM_NHT_RP)
+                       zlog_debug("%s: Embedded RP %pPA learned but no next hop", __func__,
+                                  &rp_info->rp.rpf_addr);
+       }
 }
 
 void pim_embedded_rp_delete(struct pim_instance *pim, const pim_addr *group)