]> git.puffer.fish Git - matthieu/frr.git/commitdiff
eigrpd: Fixup some SA issues
authorDonald Sharp <sharpd@cumulusnetworks.com>
Tue, 5 Dec 2017 14:52:16 +0000 (09:52 -0500)
committerDonald Sharp <sharpd@cumulusnetworks.com>
Mon, 11 Dec 2017 13:42:51 +0000 (08:42 -0500)
1) strlen(buf) on an uninted value is the wrong thing to do
we should be getting sizeof(buf)

2) tlv is not freed in this error case, so let's free it up.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
eigrpd/eigrp_reply.c

index 0ccffde72bf0e6f096f13cae025f3bdf5436df4e..84396f0878ac36c4859a4a163aa7ce69a420f3d0 100644 (file)
@@ -170,9 +170,11 @@ void eigrp_reply_receive(struct eigrp *eigrp, struct ip *iph,
                 */
                if (!dest) {
                        char buf[PREFIX_STRLEN];
+
                        zlog_err("%s: Received prefix %s which we do not know about",
                                 __PRETTY_FUNCTION__,
-                                prefix2str(&dest_addr, buf, strlen(buf)));
+                                prefix2str(&dest_addr, buf, sizeof(buf)));
+                       eigrp_IPv4_InternalTLV_free(tlv);
                        continue;
                }