]> git.puffer.fish Git - mirror/frr.git/commitdiff
tools: fix regression in gen_northbound_callback tool 17885/head
authorChristian Hopps <chopps@labn.net>
Mon, 20 Jan 2025 06:01:59 +0000 (06:01 +0000)
committerChristian Hopps <chopps@labn.net>
Mon, 20 Jan 2025 06:01:59 +0000 (06:01 +0000)
When support for new style `get()` was added inadvertently stopped
generating other callbacks and prototypes. Fix this.

Signed-off-by: Christian Hopps <chopps@labn.net>
tools/gen_northbound_callbacks.c

index 019404d7ccf30851a2aab6ee36859e7e82b93756..87ba43eaa24292b037f3ef0eefcf30ea2c5e7055 100644 (file)
@@ -238,12 +238,10 @@ static int generate_prototypes(const struct lysc_node *snode, void *arg)
                generate_callback_name(snode, cb->operation, cb_name,
                                       sizeof(cb_name));
 
-               if (cb->operation == NB_CB_GET_ELEM) {
-                       if (f_new_cbs)
-                               generate_prototype(&nb_oper_get, cb_name);
-                       else
-                               generate_prototype(cb, cb_name);
-               }
+               if (cb->operation == NB_CB_GET_ELEM && f_new_cbs)
+                       generate_prototype(&nb_oper_get, cb_name);
+               else
+                       generate_prototype(cb, cb_name);
 
                if (cb->need_config_write && need_config_write) {
                        generate_config_write_cb_name(snode, cb_name,
@@ -344,12 +342,10 @@ static int generate_callbacks(const struct lysc_node *snode, void *arg)
                generate_callback_name(snode, cb->operation, cb_name,
                                       sizeof(cb_name));
 
-               if (cb->operation == NB_CB_GET_ELEM) {
-                       if (f_new_cbs)
-                               generate_callback(&nb_oper_get, cb_name);
-                       else
-                               generate_callback(cb, cb_name);
-               }
+               if (cb->operation == NB_CB_GET_ELEM && f_new_cbs)
+                       generate_callback(&nb_oper_get, cb_name);
+               else
+                       generate_callback(cb, cb_name);
 
                if (cb->need_config_write && need_config_write) {
                        generate_config_write_cb_name(snode, cb_name,