]> git.puffer.fish Git - matthieu/frr.git/commitdiff
ospfd: compare prefix values in host order
authorChristian Hopps <chopps@labn.net>
Sun, 6 Feb 2022 20:01:28 +0000 (15:01 -0500)
committerMergify <37929162+mergify[bot]@users.noreply.github.com>
Wed, 22 Feb 2023 16:55:11 +0000 (16:55 +0000)
Signed-off-by: Christian Hopps <chopps@labn.net>
(cherry picked from commit 156a904cae87a1ea1cd51de5012c9bddc0d63747)

ospfd/ospf_apiserver.c

index 6fd1c82c2447ab2ea406df295fb2231d271e8520..ee29ed8aaef7f04a0ee639d0a3ffe143300fa4e7 100644 (file)
@@ -2593,9 +2593,12 @@ static inline int cmp_route_nodes(struct route_node *orn,
                return 1;
        else if (!nrn)
                return -1;
-       else if (orn->p.u.prefix4.s_addr < nrn->p.u.prefix4.s_addr)
+
+       uint32_t opn = ntohl(orn->p.u.prefix4.s_addr);
+       uint32_t npn = ntohl(nrn->p.u.prefix4.s_addr);
+       if (opn < npn)
                return -1;
-       else if (orn->p.u.prefix4.s_addr > nrn->p.u.prefix4.s_addr)
+       else if (opn > npn)
                return 1;
        else
                return 0;