]> git.puffer.fish Git - mirror/frr.git/commitdiff
lib: Convert to errors some issues in buffer.c
authorDonald Sharp <sharpd@cumulusnetworks.com>
Mon, 20 Aug 2018 13:05:23 +0000 (09:05 -0400)
committerQuentin Young <qlyoung@cumulusnetworks.com>
Thu, 6 Sep 2018 20:50:58 +0000 (20:50 +0000)
Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
lib/buffer.c

index 1799c6b94f3c79bde7f161d54ec22c53c26be377..bed42f047f3cc415b824f57438e258997e4b1516 100644 (file)
@@ -365,8 +365,9 @@ buffer_status_t buffer_flush_window(struct buffer *b, int fd, int width,
                        iov_size =
                                ((iov_index > IOV_MAX) ? IOV_MAX : iov_index);
                        if ((nbytes = writev(fd, c_iov, iov_size)) < 0) {
-                               zlog_warn("%s: writev to fd %d failed: %s",
-                                         __func__, fd, safe_strerror(errno));
+                               flog_err(LIB_ERR_SOCKET,
+                                        "%s: writev to fd %d failed: %s",
+                                        __func__, fd, safe_strerror(errno));
                                break;
                        }
 
@@ -377,8 +378,9 @@ buffer_status_t buffer_flush_window(struct buffer *b, int fd, int width,
        }
 #else  /* IOV_MAX */
        if ((nbytes = writev(fd, iov, iov_index)) < 0)
-               zlog_warn("%s: writev to fd %d failed: %s", __func__, fd,
-                         safe_strerror(errno));
+               flog_err(LIB_ERR_SOCKET,
+                        "%s: writev to fd %d failed: %s", __func__, fd,
+                        safe_strerror(errno));
 #endif /* IOV_MAX */
 
        /* Free printed buffer data. */
@@ -438,7 +440,8 @@ in one shot. */
                if (ERRNO_IO_RETRY(errno))
                        /* Calling code should try again later. */
                        return BUFFER_PENDING;
-               zlog_warn("%s: write error on fd %d: %s", __func__, fd,
+               flog_err(LIB_ERR_SOCKET,
+                        "%s: write error on fd %d: %s", __func__, fd,
                          safe_strerror(errno));
                return BUFFER_ERROR;
        }
@@ -493,8 +496,9 @@ buffer_status_t buffer_write(struct buffer *b, int fd, const void *p,
                if (ERRNO_IO_RETRY(errno))
                        nbytes = 0;
                else {
-                       zlog_warn("%s: write error on fd %d: %s", __func__, fd,
-                                 safe_strerror(errno));
+                       flog_err(LIB_ERR_SOCKET,
+                                "%s: write error on fd %d: %s", __func__, fd,
+                                safe_strerror(errno));
                        return BUFFER_ERROR;
                }
        }