]> git.puffer.fish Git - mirror/frr.git/commitdiff
mgmtd: remove unused "placeholder" code.
authorChristian Hopps <chopps@labn.net>
Tue, 27 Jun 2023 18:12:39 +0000 (14:12 -0400)
committerMergify <37929162+mergify[bot]@users.noreply.github.com>
Thu, 29 Jun 2023 22:15:12 +0000 (22:15 +0000)
We don't need un-run/un-tested placeholder code we may never need.

Signed-off-by: Christian Hopps <chopps@labn.net>
(cherry picked from commit 70fb3910dbe81c8d44dcfa77c070b0a6e83d3607)

lib/mgmt.proto
lib/mgmt_be_client.c
mgmtd/mgmt_be_adapter.c

index 14d00fa10064e0930dc5c2f1c8e5410ea99f4d04..9e4b39abe4d2f1cf0f1a152aa37419c58c5e4fa2 100644 (file)
@@ -136,28 +136,6 @@ message BeOperDataGetReply {
   optional YangDataReply data = 5;
 }
 
-message BeOperDataNotify {
-  required YangDataReply data = 5;
-}
-
-message BeConfigCmdReq {
-  required string cmd = 1;
-}
-
-message BeConfigCmdReply {
-  required bool success = 1;
-  required string error_if_any = 2;
-}
-
-message BeShowCmdReq {
-  required string cmd = 1;
-}
-
-message BeShowCmdReply {
-  required bool success = 1;
-  required string cmd_ouput = 2;
-}
-
 //
 // Any message on the MGMTD Backend Interface.
 //
@@ -173,11 +151,6 @@ message BeMessage {
     BeCfgDataApplyReply cfg_apply_reply = 9;
     BeOperDataGetReq get_req = 10;
     BeOperDataGetReply get_reply = 11;
-    BeOperDataNotify notify_data = 12;
-    BeConfigCmdReq cfg_cmd_req = 13;
-    BeConfigCmdReply cfg_cmd_reply = 14;
-    BeShowCmdReq show_cmd_req = 15;
-    BeShowCmdReply show_cmd_reply = 16;
   }
 }
 
index fdeff3ec0a47a9634ac2e6dfdb848c7bef128157..7bd9980357d5039611e0be460c39256ab20c05cd 100644 (file)
@@ -768,9 +768,6 @@ static int mgmt_be_client_handle_msg(struct mgmt_be_client *client_ctx,
                        client_ctx, (uint64_t)be_msg->cfg_apply_req->txn_id);
                break;
        case MGMTD__BE_MESSAGE__MESSAGE_GET_REQ:
-       case MGMTD__BE_MESSAGE__MESSAGE_SUBSCR_REQ:
-       case MGMTD__BE_MESSAGE__MESSAGE_CFG_CMD_REQ:
-       case MGMTD__BE_MESSAGE__MESSAGE_SHOW_CMD_REQ:
                MGMTD_BE_CLIENT_ERR("Got unhandled message type %u",
                                    be_msg->message_case);
                /*
@@ -781,13 +778,11 @@ static int mgmt_be_client_handle_msg(struct mgmt_be_client *client_ctx,
         * NOTE: The following messages are always sent from Backend
         * clients to MGMTd only and/or need not be handled here.
         */
+       case MGMTD__BE_MESSAGE__MESSAGE_SUBSCR_REQ:
        case MGMTD__BE_MESSAGE__MESSAGE_GET_REPLY:
        case MGMTD__BE_MESSAGE__MESSAGE_TXN_REPLY:
        case MGMTD__BE_MESSAGE__MESSAGE_CFG_DATA_REPLY:
        case MGMTD__BE_MESSAGE__MESSAGE_CFG_APPLY_REPLY:
-       case MGMTD__BE_MESSAGE__MESSAGE_CFG_CMD_REPLY:
-       case MGMTD__BE_MESSAGE__MESSAGE_SHOW_CMD_REPLY:
-       case MGMTD__BE_MESSAGE__MESSAGE_NOTIFY_DATA:
        case MGMTD__BE_MESSAGE__MESSAGE__NOT_SET:
        default:
                /*
index 512cc49feb550177ef00ed3ce7cf634f218a7f81..5e9d5a1104fcf1e385894265036e1b8185c40a08 100644 (file)
@@ -532,9 +532,6 @@ mgmt_be_adapter_handle_msg(struct mgmt_be_client_adapter *adapter,
                        be_msg->cfg_apply_reply->error_if_any, adapter);
                break;
        case MGMTD__BE_MESSAGE__MESSAGE_GET_REPLY:
-       case MGMTD__BE_MESSAGE__MESSAGE_CFG_CMD_REPLY:
-       case MGMTD__BE_MESSAGE__MESSAGE_SHOW_CMD_REPLY:
-       case MGMTD__BE_MESSAGE__MESSAGE_NOTIFY_DATA:
                /*
                 * TODO: Add handling code in future.
                 */
@@ -548,8 +545,6 @@ mgmt_be_adapter_handle_msg(struct mgmt_be_client_adapter *adapter,
        case MGMTD__BE_MESSAGE__MESSAGE_TXN_REQ:
        case MGMTD__BE_MESSAGE__MESSAGE_CFG_DATA_REQ:
        case MGMTD__BE_MESSAGE__MESSAGE_CFG_APPLY_REQ:
-       case MGMTD__BE_MESSAGE__MESSAGE_CFG_CMD_REQ:
-       case MGMTD__BE_MESSAGE__MESSAGE_SHOW_CMD_REQ:
        case MGMTD__BE_MESSAGE__MESSAGE__NOT_SET:
        default:
                /*