]> git.puffer.fish Git - matthieu/frr.git/commitdiff
bgpd: Have bgp ignore SIGHUP at the moment
authorDonald Sharp <sharpd@cumulusnetworks.com>
Thu, 25 Jun 2020 00:15:12 +0000 (20:15 -0400)
committerDonald Sharp <sharpd@cumulusnetworks.com>
Thu, 25 Jun 2020 00:15:12 +0000 (20:15 -0400)
SIGHUP is ostensibly supposed to reload configuration
from a fresh slate.  This is currently horribly broken
so much so that bgp just crashes.  I see no point
in trying to make this work considering the yang
work coming down the pike.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
bgpd/bgp_main.c

index f9ff99cab0699efcb2c0b6e6aa01486b474057e9..33eaf9ae74985c88f7ac95dc3ab57f1fc12cfe4c 100644 (file)
@@ -126,8 +126,18 @@ static struct frr_daemon_info bgpd_di;
 /* SIGHUP handler. */
 void sighup(void)
 {
-       zlog_info("SIGHUP received");
-
+       zlog_info("SIGHUP received, ignoring");
+
+       return;
+
+       /*
+        * This is turned off for the moment.  There is all
+        * sorts of config turned off by bgp_terminate
+        * that is not setup properly again in bgp_rest.
+        * I see no easy way to do this nor do I see that
+        * this is a desirable way to reload config
+        * given the yang work.
+        */
        /* Terminate all thread. */
        bgp_terminate();
        bgp_reset();