]> git.puffer.fish Git - matthieu/frr.git/commitdiff
ospf6d: Remove double check of default prefix
authorDonald Sharp <sharpd@nvidia.com>
Tue, 17 May 2022 20:08:01 +0000 (16:08 -0400)
committerDonald Sharp <sharpd@nvidia.com>
Fri, 20 May 2022 13:52:16 +0000 (09:52 -0400)
The ospf6_is_valid_summary_addr function is checking
to see if a prefix is the default and also then double
comparing it against the v6 prefix part.  No need to do this.

Signed-off-by: Donald Sharp <sharpd@nvidia.com>
ospf6d/ospf6_top.c

index 8f482d707771ac8d9157849dcc945ca451301111..f85bdb35b84ab93693862862a52a929daaea1605 100644 (file)
@@ -1756,14 +1756,10 @@ DEFUN(show_ipv6_ospf6_route_type_detail, show_ipv6_ospf6_route_type_detail_cmd,
 
 bool ospf6_is_valid_summary_addr(struct vty *vty, struct prefix *p)
 {
-       struct in6_addr addr_zero;
-
-       memset(&addr_zero, 0, sizeof(addr_zero));
-
-        /* Default prefix validation*/
-       if ((is_default_prefix(p)) ||
-           (!memcmp(&p->u.prefix6, &addr_zero, sizeof(struct in6_addr)))) {
-               vty_out(vty, "Default address should not be configured as summary address.\n");
+       /* Default prefix validation*/
+       if (is_default_prefix(p)) {
+               vty_out(vty,
+                       "Default address should not be configured as summary address.\n");
                return false;
        }