]> git.puffer.fish Git - matthieu/frr.git/commitdiff
isisd: The RFC states that v6 addresses are limited to 16 in a hello packet
authorDonald Sharp <sharpd@cumulusnetworks.com>
Wed, 5 Jun 2019 01:15:43 +0000 (21:15 -0400)
committerDonald Sharp <sharpd@cumulusnetworks.com>
Wed, 5 Jun 2019 01:15:43 +0000 (21:15 -0400)
The RFC states we can send only up to 16 v6 addresses in a hello packet
and cannot send sub tlv's of that type.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
isisd/isis_tlvs.c

index 6b8e74f07ba872025760ca7739980bb04fb724db..6edfeb4c97ccfca547a1c83bbed64776c76419c5 100644 (file)
@@ -3271,13 +3271,18 @@ void isis_tlvs_add_ipv6_addresses(struct isis_tlvs *tlvs,
 {
        struct listnode *node;
        struct prefix_ipv6 *ip_addr;
+       unsigned int addr_count = 0;
 
        for (ALL_LIST_ELEMENTS_RO(addresses, node, ip_addr)) {
+               if (addr_count >= 15)
+                       break;
+
                struct isis_ipv6_address *a =
                        XCALLOC(MTYPE_ISIS_TLV, sizeof(*a));
 
                a->addr = ip_addr->prefix;
                append_item(&tlvs->ipv6_address, (struct isis_item *)a);
+               addr_count++;
        }
 }