bgpd: fix memory leaks in route_match_alias

Signed-off-by: Igor Ryzhov <iryzhov@nfware.com>

diff --git a/bgpd/bgp_routemap.c b/bgpd/bgp_routemap.c
index 09dd71c0205db663675e758b911b9a6a659b6ed8..0e13b43ec8255ec30402247951fe6f8bb0535179 100644 (file)
--- a/bgpd/bgp_routemap.c
+++ b/bgpd/bgp_routemap.c
@@ -1189,27 +1189,38 @@ route_match_alias(void *rule, const struct prefix *prefix, void *object)
        struct bgp_path_info *path = object;
        char **communities;
        int num;
+       bool found;
 
        if (path->attr->community) {
+               found = false;
                frrstr_split(path->attr->community->str, " ", &communities,
                             &num);
                for (int i = 0; i < num; i++) {
                        const char *com2alias =
                                bgp_community2alias(communities[i]);
-                       if (strcmp(alias, com2alias) == 0)
-                               return RMAP_MATCH;
+                       if (!found && strcmp(alias, com2alias) == 0)
+                               found = true;
+                       XFREE(MTYPE_TMP, communities[i]);
                }
+               XFREE(MTYPE_TMP, communities);
+               if (found)
+                       return RMAP_MATCH;
        }
 
        if (path->attr->lcommunity) {
+               found = false;
                frrstr_split(path->attr->lcommunity->str, " ", &communities,
                             &num);
                for (int i = 0; i < num; i++) {
                        const char *com2alias =
                                bgp_community2alias(communities[i]);
-                       if (strcmp(alias, com2alias) == 0)
-                               return RMAP_MATCH;
+                       if (!found && strcmp(alias, com2alias) == 0)
+                               found = false;
+                       XFREE(MTYPE_TMP, communities[i]);
                }
+               XFREE(MTYPE_TMP, communities);
+               if (found)
+                       return RMAP_MATCH;
        }
 
        return RMAP_NOMATCH;