]> git.puffer.fish Git - mirror/pve-network.git/commitdiff
tests: mocking more functions to avoid system access
authorStefan Lendl <s.lendl@proxmox.com>
Tue, 2 Apr 2024 11:07:40 +0000 (13:07 +0200)
committerThomas Lamprecht <t.lamprecht@proxmox.com>
Thu, 4 Apr 2024 14:50:08 +0000 (16:50 +0200)
previously extracted functions are now mocked in the zone tests

Signed-off-by: Stefan Lendl <s.lendl@proxmox.com>
Reviewed-by: Max Carrara <m.carrara@proxmox.com>
Tested-by: Max Carrara <m.carrara@proxmox.com>
Tested-By: Stefan Hanreich <s.hanreich@proxmox.com>
src/test/run_test_zones.pl

index 5354e4d30fe59eee4ebf2e93474e8718d4b1e048..274a1199898a9f08be9fc9adfa24aec5032bd248 100755 (executable)
@@ -46,8 +46,20 @@ foreach my $test (@tests) {
            return 'localhost';
        },
        read_file => sub {
+           # HACK this assumes we are always calling PVE::INotify::read_file('interfaces');
            return $interfaces_config;
        },
+       read_etc_network_interfaces => sub {
+           return $interfaces_config;
+       },
+    );
+
+    my $mocked_pve_sdn_controllers;
+    $mocked_pve_sdn_controllers = Test::MockModule->new('PVE::Network::SDN::Controllers');
+    $mocked_pve_sdn_controllers->mock(
+       read_etc_network_interfaces => sub {
+           return $interfaces_config;
+       }
     );
 
     my $pve_sdn_subnets;
@@ -87,6 +99,25 @@ foreach my $test (@tests) {
        },
     );
 
+    my ($first_plugin) = %{$sdn_config->{controllers}->{ids}} if defined $sdn_config->{controllers};
+    if ($first_plugin) {
+       my $controller_plugin = PVE::Network::SDN::Controllers::Plugin->lookup(
+           $sdn_config->{controllers}->{ids}->{$first_plugin}->{type}
+       );
+       my $mocked_controller_plugin = Test::MockModule->new($controller_plugin);
+       $mocked_controller_plugin->mock(
+           write_controller_config => sub {
+               return;
+           },
+           reload_controller => sub {
+               return;
+           },
+           read_local_frr_config => sub {
+               return;
+           },
+       );
+    }
+
     my $name = $test;
     my $expected = read_file("./$test/expected_sdn_interfaces");