subnet: dhcp: improve Net::IP usage

This simplifies the comparison of IPs by using the object-oriented
interface over the procedural one. Also instantiate the ips using the
new method rather than using new, which isn't a keyword in Perl. This
fixes the respective perlcritic warning.

Signed-off-by: Stefan Hanreich <s.hanreich@proxmox.com>
Tested-by: Hannes Duerr <h.duerr@proxmox.com>
Link: https://lore.proxmox.com/20250307125056.169575-1-s.hanreich@proxmox.com
Signed-off-by: Thomas Lamprecht <t.lamprecht@proxmox.com>

diff --git a/src/PVE/Network/SDN/SubnetPlugin.pm b/src/PVE/Network/SDN/SubnetPlugin.pm
index e73d97a84fc0d5b9e97885fc703d9242ae25c067..faf1a05153bd175690152cfc0775797b893eb354 100644 (file)
--- a/src/PVE/Network/SDN/SubnetPlugin.pm
+++ b/src/PVE/Network/SDN/SubnetPlugin.pm
@@ -86,13 +86,13 @@ sub validate_dhcp_ranges {
        my $dhcp_start = $dhcp_range->{'start-address'};
        my $dhcp_end = $dhcp_range->{'end-address'};
 
-       my $start_ip = new Net::IP($dhcp_start);
+       my $start_ip = Net::IP->new($dhcp_start);
        raise_param_exc({ 'dhcp-range' => "start-adress is not a valid IP $dhcp_start" }) if !$start_ip;
 
-       my $end_ip = new Net::IP($dhcp_end);
+       my $end_ip = Net::IP->new($dhcp_end);
        raise_param_exc({ 'dhcp-range' => "end-adress is not a valid IP $dhcp_end" }) if !$end_ip;
 
-       if (Net::IP::ip_bincomp($end_ip->binip(), 'lt', $start_ip->binip()) == 1) {
+       if ($start_ip->bincomp('gt', $end_ip)) {
            raise_param_exc({ 'dhcp-range' => "start-address $dhcp_start must be smaller than end-address $dhcp_end" })
        }