]> git.puffer.fish Git - mirror/frr.git/commitdiff
ospfd: compare prefix values in host order
authorChristian Hopps <chopps@labn.net>
Sun, 6 Feb 2022 20:01:28 +0000 (15:01 -0500)
committerChristian Hopps <chopps@gmail.com>
Mon, 20 Feb 2023 16:58:30 +0000 (11:58 -0500)
Signed-off-by: Christian Hopps <chopps@labn.net>
ospfd/ospf_apiserver.c

index 728945032b8301c753288db8f7ae9d8a67485c79..5e4fc30a2880417d9be8a0faf3114ae2df06b871 100644 (file)
@@ -2578,9 +2578,12 @@ static inline int cmp_route_nodes(struct route_node *orn,
                return 1;
        else if (!nrn)
                return -1;
-       else if (orn->p.u.prefix4.s_addr < nrn->p.u.prefix4.s_addr)
+
+       uint32_t opn = ntohl(orn->p.u.prefix4.s_addr);
+       uint32_t npn = ntohl(nrn->p.u.prefix4.s_addr);
+       if (opn < npn)
                return -1;
-       else if (orn->p.u.prefix4.s_addr > nrn->p.u.prefix4.s_addr)
+       else if (opn > npn)
                return 1;
        else
                return 0;