]> git.puffer.fish Git - matthieu/frr.git/commitdiff
bgpd: bgp_path_info_mpath_next only returns values
authorDonald Sharp <sharpd@cumulusnetworks.com>
Sat, 26 Oct 2019 01:10:31 +0000 (21:10 -0400)
committerDonald Sharp <sharpd@cumulusnetworks.com>
Sat, 26 Oct 2019 01:10:31 +0000 (21:10 -0400)
Since we don't set a value from the return of bgp_path_info_mpath_next
it is impossible for this function to do anything as such the if statement
is dead code as well.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>
bgpd/bgp_mpath.c

index 648c3be47e07c8426bb353f4de9dadace57bf7d3..d37bf5473466b3e1fbcd923b15d3c3eda59f22b4 100644 (file)
@@ -614,8 +614,6 @@ void bgp_path_info_mpath_update(struct bgp_node *rn,
                        if ((mpath_count < maxpaths) && (new_mpath != new_best)
                            && bgp_path_info_nexthop_cmp(prev_mpath,
                                                         new_mpath)) {
-                               if (new_mpath == next_mpath)
-                                       bgp_path_info_mpath_next(new_mpath);
                                bgp_path_info_mpath_dequeue(new_mpath);
 
                                bgp_path_info_mpath_enqueue(prev_mpath,