bgpd: Avoid using assignments within checks

Signed-off-by: Donatas Abraitis <donatas.abraitis@gmail.com>

diff --git a/bgpd/bgp_attr.c b/bgpd/bgp_attr.c
index 2f0751a5f045ed1ed98c589aa0c93761e1519b07..1bf48b225b17be0ee8ae4cb1bdafcabae9648e4d 100644 (file)
--- a/bgpd/bgp_attr.c
+++ b/bgpd/bgp_attr.c
@@ -3317,7 +3317,8 @@ bgp_attr_parse_ret_t bgp_attr_parse(struct peer *peer, struct attr *attr,
        }
 
        /* Check all mandatory well-known attributes are present */
-       if ((ret = bgp_attr_check(peer, attr)) < 0)
+       ret = bgp_attr_check(peer, attr);
+       if (ret < 0)
                goto done;
 
        /*