lib: fix the right value is returned for fail cases

Currently `bfd_get_peer_info` should return invalid sp->family
and dp->family during fail cases.

Before this fix, in those fail cases `bfd_get_peer_info` maybe
return valid sp->family and dp->family.

This fix ensures all fail cases return invalid sp->family and
dp->family for outside callers.

Signed-off-by: anlan_cs <anlan_cs@tom.com>

diff --git a/lib/bfd.c b/lib/bfd.c
index e3642974572a66b13a7d4f89a5f6f5331a217cd7..7b711a9fba3d8786c167a33b536302a6e686b519 100644 (file)
--- a/lib/bfd.c
+++ b/lib/bfd.c
@@ -171,6 +171,12 @@ static struct interface *bfd_get_peer_info(struct stream *s, struct prefix *dp,
        return ifp;
 
 stream_failure:
+       /*
+        * Clean dp and sp because caller
+        * will immediately check them valid or not
+        */
+       memset(dp, 0, sizeof(*dp));
+       memset(sp, 0, sizeof(*sp));
        return NULL;
 }