]> git.puffer.fish Git - matthieu/frr.git/commitdiff
bgpd: Drop unnecessary null-termination for fqdn
authorDonatas Abraitis <donatas@opensourcerouting.org>
Wed, 25 Oct 2023 04:52:38 +0000 (07:52 +0300)
committerDonatas Abraitis <donatas@opensourcerouting.org>
Wed, 25 Oct 2023 04:52:38 +0000 (07:52 +0300)
str[len] is already null terminated before:

```
if (len > BGP_MAX_HOSTNAME) {
memcpy(&str, data, BGP_MAX_HOSTNAME);
str[BGP_MAX_HOSTNAME] = '\0';
} else if (len) {
memcpy(&str, data, len);
str[len] = '\0';
}
```

CID: 1569357

Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
bgpd/bgp_packet.c

index f955c5057791139319915ab628a013e25b5e013d..08c3cbdea90d735332b01473a44dd043434c791d 100644 (file)
@@ -3307,8 +3307,6 @@ static void bgp_dynamic_capability_fqdn(uint8_t *pnt, int action,
                data += len;
 
                if (len) {
-                       str[len] = '\0';
-
                        XFREE(MTYPE_BGP_PEER_HOST, peer->hostname);
                        XFREE(MTYPE_BGP_PEER_HOST, peer->domainname);