ripd, ripngd: Free up list after call into nb_cli_rpc

We have a clear memory leak after running `clear ip rip`
Fix this.

Signed-off-by: Donald Sharp <sharpd@cumulusnetworks.com>

diff --git a/ripd/rip_cli.c b/ripd/rip_cli.c
index 5c26c0cef73ceec970471523e27f0762a62d0dba..7e2394f4732a5634fd8b14ee117c34ae3d316e89 100644 (file)
--- a/ripd/rip_cli.c
+++ b/ripd/rip_cli.c
@@ -1001,6 +1001,7 @@ DEFPY (clear_ip_rip,
        VRF_CMD_HELP_STR)
 {
        struct list *input;
+       int ret;
 
        input = list_new();
        if (vrf) {
@@ -1011,7 +1012,11 @@ DEFPY (clear_ip_rip,
                listnode_add(input, yang_vrf);
        }
 
-       return nb_cli_rpc("/frr-ripd:clear-rip-route", input, NULL);
+       ret = nb_cli_rpc("/frr-ripd:clear-rip-route", input, NULL);
+
+       list_delete(&input);
+
+       return ret;
 }
 
 void rip_cli_init(void)

diff --git a/ripngd/ripng_cli.c b/ripngd/ripng_cli.c
index 2d9930e3576d76a93f2d81f489e30a90e8b0c2fc..b3d92fb0d90337164d0ec56d89f6b37f13c4b122 100644 (file)
--- a/ripngd/ripng_cli.c
+++ b/ripngd/ripng_cli.c
@@ -485,6 +485,7 @@ DEFPY (clear_ipv6_rip,
        VRF_CMD_HELP_STR)
 {
        struct list *input;
+       int ret;
 
        input = list_new();
        if (vrf) {
@@ -495,7 +496,11 @@ DEFPY (clear_ipv6_rip,
                listnode_add(input, yang_vrf);
        }
 
-       return nb_cli_rpc("/frr-ripngd:clear-ripng-route", input, NULL);
+       ret = nb_cli_rpc("/frr-ripngd:clear-ripng-route", input, NULL);
+
+       list_delete(&input);
+
+       return ret;
 }
 
 void ripng_cli_init(void)